Skip to content

Fix extractGeckoLogs for structured Log marker format (bug 2022540)#5927

Merged
canova merged 2 commits intofirefox-devtools:mainfrom
padenot:fix-extract-gecko-logs
Apr 7, 2026
Merged

Fix extractGeckoLogs for structured Log marker format (bug 2022540)#5927
canova merged 2 commits intofirefox-devtools:mainfrom
padenot:fix-extract-gecko-logs

Conversation

@padenot
Copy link
Copy Markdown
Contributor

@padenot padenot commented Apr 1, 2026

Bug 2022540 switched Log markers from {module, name} fields to structured {level, message} fields, with the module name stored as the marker name. The old format used a single module string that could include the log level prefix (e.g. D/cubeb); the new format uses an integer level field.

Profiles use one format exclusively, never a mix. We detect which by checking the first Log marker found in each thread. This also types things a little more.

Bug 2022540 switched Log markers from {module, name} fields to structured
{level, message} fields, with the module name stored as the marker name.
The old format used a single module string that could include the log level
prefix (e.g. D/cubeb); the new format uses an integer level field.

Profiles use one format exclusively, never a mix. We detect which by
checking the first Log marker found in each thread.
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.44%. Comparing base (46e3594) to head (53f66c9).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/utils/window-console.ts 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5927      +/-   ##
==========================================
- Coverage   85.45%   85.44%   -0.01%     
==========================================
  Files         321      321              
  Lines       32068    32070       +2     
  Branches     8745     8744       -1     
==========================================
  Hits        27403    27403              
- Misses       4234     4236       +2     
  Partials      431      431              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@canova canova self-requested a review April 7, 2026 15:45
Copy link
Copy Markdown
Member

@canova canova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@canova canova enabled auto-merge (squash) April 7, 2026 17:23
@canova canova merged commit b41e166 into firefox-devtools:main Apr 7, 2026
19 checks passed
@fatadel fatadel mentioned this pull request Apr 28, 2026
fatadel added a commit that referenced this pull request Apr 28, 2026
Changes:

[Nazım Can Altınova] Add Adel to the automatic dependency reviews
(#5930)
[fatadel] Fix arrow panel appearing behind marker tooltips (#5926)
[fatadel] Upgrade Node.js from v22 to v24 (#5923)
[Markus Stange] Use createStackTableBySkippingDiscarded in focusSelf.
(#5916)
[Markus Stange] Propagate isJS to symbolicated funcs (#5907)
[Markus Stange] Always render the CPU-usage-aware activity graph when
CPU information is available (#5918)
[Nazım Can Altınova] Fallback to javascript highlighting in the source
view as a backup (#5936)
[Nazım Can Altınova] Properly type the return value of
_languageExtForPath (#5937)
[Nazım Can Altınova] Update typescript eslint dependencies (#5938)
[Markus Stange] Modernize more of the transform functions (#5934)
[Paul Adenot] Fix extractGeckoLogs for structured Log marker format (bug
2022540) (#5927)
[Nazım Can Altınova] Move some profile fetching code into a separate
module. (#5939)
[Markus Stange] Update the hovered item when panning any viewport canvas
(#5903)
[Markus Stange] Migrate Home page animation to CSS transitions and
remove react-transition-group (#5649)
[Nazım Can Altınova] Fix test/lint commands on Windows and fix CI
(#5947)
[Nazım Can Altınova] Convert profile-logic/js-tracer.tsx to a ts file
(#5942)
[Markus Stange] Remove panelLayoutGeneration (#5946)
[fatadel] Add CounterDisplayConfig to counters in the processed profile
format (#5912)
[Nazım Can Altınova] Fix eslint-config-prettier silently overriding
custom rules (#5955)
[fatadel] Dim non-matching nodes in the stack chart when searching
(#5935)
[Nazım Can Altınova] Fix loading .json.gz profiles from inside zip
archives (#5959)
[Ryan Hunt] Add a fullscreen button to the bottom box (#5605)
[Markus Stange] Speed up _computeCallNodeTableHierarchy by keeping
siblings ordered by func (#5964)
[Markus Stange] Replace symbolicator-cli with a profiler-edit node tool
(#5965)
[Nazım Can Altınova] Add "Include idle samples" toggle to the call tree
settings (#5968)
[Nazım Can Altınova] Add dark mode versions of the fullscreen icons
(#5972)
[fatadel] Replace 4 counter track components with a single generic
TrackCounter (#5944)
[fatadel] Use ephemeral port for esbuild's internal dev server (#5974)
[carverdamien] Remove category from LongTaskMarkerPayload (#5975)

And special thanks to our localizers:

de: Ger 
de: Michael Köhler 
el: Jim Spentzos 
en-GB: Ian Neal 
es-CL: ravmn 
fr: Théo Chevalier 
ia: Melo46 
it: Francesco Lodolo [:flod] 
nl: Mark Heijl 
pt-BR: Marcelo Ghelman 
ru: Valery Ledovskoy 
ru: berry 
sv-SE: Andreas Pettersson 
tr: Grk 
zh-CN: Olvcpr423 
zh-CN: wxie 
zh-TW: Pin-guang Chen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants