Skip to content

Sort power tracks, and show them right after the other counter tracks.#4470

Merged
canova merged 1 commit into
firefox-devtools:mainfrom
fqueze:sort-power-tracks
Feb 14, 2023
Merged

Sort power tracks, and show them right after the other counter tracks.#4470
canova merged 1 commit into
firefox-devtools:mainfrom
fqueze:sort-power-tracks

Conversation

@fqueze
Copy link
Copy Markdown
Contributor

@fqueze fqueze commented Feb 14, 2023

@fqueze fqueze requested a review from canova February 14, 2023 12:00
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 14, 2023

Codecov Report

Base: 88.64% // Head: 88.63% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (035ff1b) compared to base (a31d803).
Patch coverage: 62.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4470      +/-   ##
==========================================
- Coverage   88.64%   88.63%   -0.01%     
==========================================
  Files         284      284              
  Lines       25528    25536       +8     
  Branches     6860     6865       +5     
==========================================
+ Hits        22629    22634       +5     
- Misses       2692     2695       +3     
  Partials      207      207              
Impacted Files Coverage Δ
src/profile-logic/tracks.js 82.66% <62.50%> (-0.30%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Member

@canova canova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

I tested manually and it's working well. There isn't a test for this case but after discussing it we decided to not add for it because it's a very self contained patch and I don't think someone could unintentionally break it unless they are changing this part directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants