Make cause.time optional#4408
Conversation
Codecov ReportBase: 88.56% // Head: 88.56% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4408 +/- ##
=======================================
Coverage 88.56% 88.56%
=======================================
Files 282 282
Lines 25488 25489 +1
Branches 6862 6864 +2
=======================================
+ Hits 22573 22574 +1
Misses 2708 2708
Partials 207 207
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
julienw
left a comment
There was a problem hiding this comment.
This looks reasonable to me, I don't think this needs an upgrader because we make the type more permissive.
A version bump could be useful to make sure that the code is updated when they see a profile with an undefined cause.time. This won't happen for the firefox profiler, I'll let you decide if you need it for your code.
|
You're right, I was unsure on updating the version number. |
A tiny PR that makes the
timefield in markercausefields optional: Usually, the stack trace has been gathered at the same time as the marker, recording the specific time is therefore not always required, as using the event start time is a good default.