Skip to content

Make cause.time optional#4408

Merged
julienw merged 2 commits into
firefox-devtools:mainfrom
parttimenerd:parttimenerd_cause_time_optional
Jan 10, 2023
Merged

Make cause.time optional#4408
julienw merged 2 commits into
firefox-devtools:mainfrom
parttimenerd:parttimenerd_cause_time_optional

Conversation

@parttimenerd
Copy link
Copy Markdown
Contributor

A tiny PR that makes the time field in marker cause fields optional: Usually, the stack trace has been gathered at the same time as the marker, recording the specific time is therefore not always required, as using the event start time is a good default.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 9, 2023

Codecov Report

Base: 88.56% // Head: 88.56% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (24a24d4) compared to base (edd7300).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4408   +/-   ##
=======================================
  Coverage   88.56%   88.56%           
=======================================
  Files         282      282           
  Lines       25488    25489    +1     
  Branches     6862     6864    +2     
=======================================
+ Hits        22573    22574    +1     
  Misses       2708     2708           
  Partials      207      207           
Impacted Files Coverage Δ
src/components/tooltip/Marker.js 98.44% <100.00%> (ø)
src/profile-logic/process-profile.js 91.00% <100.00%> (ø)
src/profile-logic/processed-profile-versioning.js 85.36% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Contributor

@julienw julienw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me, I don't think this needs an upgrader because we make the type more permissive.
A version bump could be useful to make sure that the code is updated when they see a profile with an undefined cause.time. This won't happen for the firefox profiler, I'll let you decide if you need it for your code.

@parttimenerd
Copy link
Copy Markdown
Contributor Author

You're right, I was unsure on updating the version number.

@julienw julienw merged commit 7731900 into firefox-devtools:main Jan 10, 2023
@julienw julienw mentioned this pull request Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants