Skip to content

[BUG]: Redundant Database Query in POST /forms/fill #149

@Acuspeedster

Description

@Acuspeedster

name: 🐛 Bug Report
about: Create a report to help us improve FireForm.
title: "[BUG]: Redundant get_template() DB query in POST /forms/fill"
labels: bug
assignees: ''

⚡️ Describe the Bug

fill_form route calls:

get_template(db, id)

twice:

  • First call → truthiness check
  • Second call → actual use

This doubles SELECT queries per request.

📉 Expected Behavior

Single DB query per request.


🕵️ Possible Fix

Store result in variable, check for None, reuse object.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions