fix(dynamic-links): fix crash when building dynamic link with no internet#9942
Merged
russellwheatley merged 6 commits intomasterfrom Nov 17, 2022
Merged
fix(dynamic-links): fix crash when building dynamic link with no internet#9942russellwheatley merged 6 commits intomasterfrom
russellwheatley merged 6 commits intomasterfrom
Conversation
Lyokone
reviewed
Nov 16, 2022
...es/firebase_dynamic_links/firebase_dynamic_links/ios/Classes/FLTFirebaseDynamicLinksPlugin.m
Outdated
Show resolved
Hide resolved
Lyokone
approved these changes
Nov 16, 2022
pr-Mais
approved these changes
Nov 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Codec wasn't able to parse
NSUrl&NSErrorwhich was causing app to crash. I've removed them from thedetailsobject sent back to Flutter as they aren't used.The error message has also been replaced.
An unknown error has occurredfor the more helpfulThe request timed outwhich is already a description in the underlying native error.Related Issues
fixes #7911
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?