[firebase_auth] Fixes completely broken reauthenticateWithCredential method.#300
Closed
slightfoot wants to merge 2 commits intofirebase:masterfrom
Closed
[firebase_auth] Fixes completely broken reauthenticateWithCredential method.#300slightfoot wants to merge 2 commits intofirebase:masterfrom
reauthenticateWithCredential method.#300slightfoot wants to merge 2 commits intofirebase:masterfrom
Conversation
Contributor
Author
|
Looks like PR has already been submitted. Whoops. Closing because handled already by #237. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IGNORE THIS PR - Duplicate #237
Description
Last November there was a move away from the methods for each auth provider and to instead use the new credential methods. #928 c78ced7 At this point the
reauthenticateWithCredentialdart method invoked the platform channel and did not expect any response data.Along came #1911 cc7353b in July where all the auth methods were set to return a AuthResult object. However, nobody updated the platform specific code for
reauthenticateWithCredentialto return back the fields forAuthResult. This has left thereauthenticateWithCredentialmethod in dart broken since then.This PR fixes the platform specific code to account for this change.
Related Issues
Checklist
///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?