Skip to content

Disable -Wnullability-completeness on iOS and macOS.#782

Merged
jonsimantov merged 11 commits intomainfrom
bugfix/objc-disable-nullability-warning
Dec 6, 2021
Merged

Disable -Wnullability-completeness on iOS and macOS.#782
jonsimantov merged 11 commits intomainfrom
bugfix/objc-disable-nullability-warning

Conversation

@jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Dec 2, 2021 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

Disable -Wnullability-completeness on iOS and macOS, which is making the Obj-C++ build too verbose.

Also, during this PR's tests, the cached NDK version became corrupted. Added logic to the workflows to remove a bad cached NDK download, and allow the prereqs script to download the NDK normally.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Integration tests.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@google-cla google-cla bot added the cla: yes label Dec 2, 2021
@jonsimantov jonsimantov added skip-release-notes Skip release notes check tests-requested: quick Trigger a quick set of integration tests. and removed cla: yes labels Dec 2, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Dec 2, 2021
@github-actions
Copy link

github-actions bot commented Dec 2, 2021 •
edited
Loading

❌  Integration test FAILED

Requested by @jonsimantov on commit 04d0fa4
Last updated: Mon Dec 6 15:25 PST 2021
View integration test log & download artifacts

Failures Configs
database [TEST] [FLAKINESS] [Android] [windows] [android_target]
(1 failed tests)  FirebaseDatabaseTest.TestInfoConnected
firestore [TEST] [ERROR] [Android] [ubuntu] [android_target]
[TEST] [FLAKINESS] [Android] [macos] [android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Dec 2, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 2, 2021
@jonsimantov jonsimantov requested a review from a-maurice December 2, 2021 21:22
@google-cla google-cla bot added the cla: yes label Dec 2, 2021
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Dec 2, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Dec 2, 2021
a-maurice
a-maurice reviewed Dec 2, 2021
View reviewed changes
@jonsimantov jonsimantov requested a review from a-maurice December 2, 2021 23:44
@jonsimantov jonsimantov enabled auto-merge (squash) December 2, 2021 23:44
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Dec 3, 2021
@github-actions github-actions bot added tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. labels Dec 3, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 3, 2021
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Dec 6, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Dec 6, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 6, 2021
@jonsimantov jonsimantov removed the tests: failed This PR's integration tests failed. label Dec 6, 2021
@jonsimantov jonsimantov disabled auto-merge December 6, 2021 19:16
@jonsimantov jonsimantov enabled auto-merge (squash) December 6, 2021 20:00
@jonsimantov jonsimantov merged commit 04d0fa4 into main Dec 6, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. labels Dec 6, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 6, 2021
@jonsimantov jonsimantov deleted the bugfix/objc-disable-nullability-warning branch December 22, 2021 22:35
@firebase firebase locked and limited conversation to collaborators Jan 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@a-maurice a-maurice a-maurice approved these changes

Assignees

@a-maurice a-maurice

Labels

cla: yes skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonsimantov @a-maurice