Skip to content

chore: update example app on how to embed SwiftUI auth in UIKit#1329

Draft
russellwheatley wants to merge 1 commit intomainfrom
test-uikit
Draft

chore: update example app on how to embed SwiftUI auth in UIKit#1329
russellwheatley wants to merge 1 commit intomainfrom
test-uikit

Conversation

@russellwheatley
Copy link
Member

  • Updated example app to demonstrate how to embed FirebaseUI Swift into UIKit app.

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a valuable example to the sample application, illustrating how to effectively integrate SwiftUI-based Firebase authentication flows into existing UIKit view hierarchies. This enhancement provides developers with a flexible approach to leverage modern SwiftUI authentication components while maintaining their established UIKit application structure, facilitating a smoother transition and adoption of new frameworks.

Highlights

  • New Example Added: A new example demonstrating how to embed FirebaseSwiftUI authentication within a UIKit application has been added.
  • UIKit Integration: The example utilizes UIViewControllerRepresentable to host a SwiftUI AuthPickerView inside a UIKit UIViewController, showcasing seamless integration.
  • Authentication Flow Demonstration: The new example includes UI elements and logic to clearly illustrate both unauthenticated and authenticated states within the embedded view.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a helpful example demonstrating how to embed Firebase's SwiftUI authentication views within a UIKit application. The implementation is generally well-structured, using UIViewControllerRepresentable to bridge between SwiftUI and UIKit. I've identified a couple of areas for improvement to enhance the clarity and correctness of the example code. Specifically, I've suggested simplifying the makeUIViewController method and refining the logic for presenting the authentication sheet to provide a more intuitive user experience. Overall, this is a valuable addition to the sample app.

Comment on lines +57 to +61
func makeUIViewController(context: Context) -> EmbeddedAuthViewController {
let viewController = EmbeddedAuthViewController()
viewController.update(authService: authService)
return viewController
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The call to viewController.update(authService: authService) is redundant because updateUIViewController(_:context:) is called by the system immediately after makeUIViewController(context:). All view controller configuration and data passing from SwiftUI should be done in updateUIViewController for clarity and to follow best practices. This also avoids performing the update work twice.

  func makeUIViewController(context: Context) -> EmbeddedAuthViewController {
    return EmbeddedAuthViewController()
  }

Comment on lines +110 to +114
.onChange(of: authService.authenticationState) { _, newValue in
if newValue != .authenticating {
authService.isPresented = newValue == .unauthenticated
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This onChange modifier automatically presents the authentication sheet whenever the user is not authenticated. This behavior can be confusing for a user, as the sheet will appear immediately upon signing out, and it makes the "Authenticate" button in your UI redundant. For an example demonstrating an embedded view, it would be clearer to allow the user to manually trigger the authentication flow via the button. I recommend removing this automatic presentation logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant