Skip to content

chore: bump @finos/git-proxy to 2.0.0#1518

Merged
jescalada merged 1 commit into
mainfrom
bump-to-2.0
May 8, 2026
Merged

chore: bump @finos/git-proxy to 2.0.0#1518
jescalada merged 1 commit into
mainfrom
bump-to-2.0

Conversation

@jescalada
Copy link
Copy Markdown
Contributor

No description provided.

@jescalada jescalada requested a review from a team as a code owner May 4, 2026 15:55
@netlify
Copy link
Copy Markdown

netlify Bot commented May 4, 2026

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit f3fbe8f
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/69f8c171c35e0c000723f856

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 2 package(s) with unknown licenses.
See the Details below.

License Issues

package-lock.json

PackageVersionLicenseIssue Type
packages/git-proxy-cli2.0.0NullUnknown License

packages/git-proxy-cli/package.json

PackageVersionLicenseIssue Type
@finos/git-proxy2.0.0NullUnknown License
Allowed Licenses: MIT, MIT-0, Apache-2.0, BSD-3-Clause, BSD-3-Clause-Clear, ISC, BSD-2-Clause, Unlicense, CC0-1.0, 0BSD, X11, MPL-2.0, MPL-1.0, MPL-1.1, MPL-2.0, OFL-1.1, Zlib, BlueOak-1.0.0, Ubuntu-font-1.0, Artistic-2.0, Python-2.0
Excluded from license check: pkg:npm/caniuse-lite, pkg:npm/path-is-inside, pkg:npm/unicode-match-property-value-ecmascript, pkg:npm/unicode-property-aliases-ecmascript, pkg:npm/uri-js

OpenSSF Scorecard

PackageVersionScoreDetails
npm/packages/git-proxy-cli 2.0.0 UnknownUnknown
npm/@finos/git-proxy 2.0.0 UnknownUnknown

Scanned Files

  • package-lock.json
  • packages/git-proxy-cli/package.json

@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.21%. Comparing base (b6d72fc) to head (f3fbe8f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1518   +/-   ##
=======================================
  Coverage   90.21%   90.21%           
=======================================
  Files          69       69           
  Lines        5511     5511           
  Branches      944      944           
=======================================
  Hits         4972     4972           
  Misses        521      521           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

1 similar comment
@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.21%. Comparing base (b6d72fc) to head (f3fbe8f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1518   +/-   ##
=======================================
  Coverage   90.21%   90.21%           
=======================================
  Files          69       69           
  Lines        5511     5511           
  Branches      944      944           
=======================================
  Hits         4972     4972           
  Misses        521      521           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We should fix the CLI license however (see dependency review comments)

@jescalada
Copy link
Copy Markdown
Contributor Author

@kriswest I believe this is a false positive - we had the same problem in the previous bump PR #1502, but the same comment never showed up in subsequent PRs after merging. I think it's just due to the @finos/git-proxy version requested by the CLI not yet being published to NPM when the CI runs.

Note how NPM does show the correct license on the release, as expected since both package.jsons have a license entry: https://www.npmjs.com/package/@finos/git-proxy/v/2.0.0-rc.6

@jescalada
Copy link
Copy Markdown
Contributor Author

Will go ahead and merge this as I'm almost sure this is due to some change in the dependency checker action...

Notably, the rc.5 bump didn't have this issue #1461, however nothing important seems to have changed between the package.json then and now.

@jescalada jescalada merged commit fd1c648 into main May 8, 2026
24 of 25 checks passed
@kriswest
Copy link
Copy Markdown
Contributor

@finos-admin and @TheJuanAndOnly99 we need some help debugging why the Git proxy docs haven't deployed with the last few merges. For Example after this merged the docs site should read "GitProxy v2.0.0 is out! 🥳" but it still says "GitProxy v2.0.0-rc.5 is out! 🥳" meaning we've missed at list two deployments (there was a v2.0.0-rc6).

@opoupeney and I got together a week ago to fix some other issues with the netlify build (including switching dependency installs from yarn to npm) and got the previews working again, but I'm not sure if this merged before or after that. Could you look into it and re-run the last deployment from main if possible?

@TheJuanAndOnly99
Copy link
Copy Markdown
Member

TheJuanAndOnly99 commented May 14, 2026

Hi @kriswest I retriggered the build and now the docs seem to have updated correctly.

I went to take a look at what may have happened when this PR was merged and why it didn't rebuild and deploy and this is what I found in the logs.

3:16:57 PM: Failed during stage 'checking build content for changes': Canceled build due to no content change

It's skipping the deploy because it thinks no content has changed. We probably need to take a look at he https://github.com/finos/git-proxy/blob/main/netlify.toml file.

All other PRs that were merged to main after this one did the same thing and exited due to no changes found.

The last PR to trigger a docs redeployment was this one #1462

@kriswest
Copy link
Copy Markdown
Contributor

Thanks @TheJuanAndOnly99 - I'll report that on and we'll discuss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants