chore: bump @finos/git-proxy to 2.0.0#1518
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Dependency ReviewThe following issues were found:
License Issuespackage-lock.json
packages/git-proxy-cli/package.json
OpenSSF Scorecard
Scanned Files
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1518 +/- ##
=======================================
Coverage 90.21% 90.21%
=======================================
Files 69 69
Lines 5511 5511
Branches 944 944
=======================================
Hits 4972 4972
Misses 521 521
Partials 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 similar comment
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1518 +/- ##
=======================================
Coverage 90.21% 90.21%
=======================================
Files 69 69
Lines 5511 5511
Branches 944 944
=======================================
Hits 4972 4972
Misses 521 521
Partials 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kriswest
left a comment
There was a problem hiding this comment.
LGTM
We should fix the CLI license however (see dependency review comments)
|
@kriswest I believe this is a false positive - we had the same problem in the previous bump PR #1502, but the same comment never showed up in subsequent PRs after merging. I think it's just due to the Note how NPM does show the correct license on the release, as expected since both |
|
Will go ahead and merge this as I'm almost sure this is due to some change in the dependency checker action... Notably, the |
|
@finos-admin and @TheJuanAndOnly99 we need some help debugging why the Git proxy docs haven't deployed with the last few merges. For Example after this merged the docs site should read "GitProxy v2.0.0 is out! 🥳" but it still says "GitProxy v2.0.0-rc.5 is out! 🥳" meaning we've missed at list two deployments (there was a v2.0.0-rc6). @opoupeney and I got together a week ago to fix some other issues with the netlify build (including switching dependency installs from yarn to npm) and got the previews working again, but I'm not sure if this merged before or after that. Could you look into it and re-run the last deployment from main if possible? |
|
Hi @kriswest I retriggered the build and now the docs seem to have updated correctly. I went to take a look at what may have happened when this PR was merged and why it didn't rebuild and deploy and this is what I found in the logs.
It's skipping the deploy because it thinks no content has changed. We probably need to take a look at he https://github.com/finos/git-proxy/blob/main/netlify.toml file. All other PRs that were merged to main after this one did the same thing and exited due to no changes found. The last PR to trigger a docs redeployment was this one #1462 |
|
Thanks @TheJuanAndOnly99 - I'll report that on and we'll discuss. |
No description provided.