Skip to content

fix: restore broken CLI package#1499

Merged
jescalada merged 6 commits intofinos:mainfrom
fabiovincenzi:fix/cli-restore
Apr 13, 2026
Merged

fix: restore broken CLI package#1499
jescalada merged 6 commits intofinos:mainfrom
fabiovincenzi:fix/cli-restore

Conversation

@fabiovincenzi
Copy link
Copy Markdown
Contributor

Fixes #1498

  • Fix TypeScript build configuration for the CLI workspace
  • Update stale imports and missing package exports that drifted from the main codebase
  • Align CLI error handling with current server API responses (403, 400, reject reason, attestation)
  • Fix test setup to load the correct configuration

@fabiovincenzi fabiovincenzi requested a review from a team as a code owner April 9, 2026 15:59
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 9, 2026

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 1b3e695
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/69d7ccdb1d346200087ff3c3

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.66%. Comparing base (c0b4a8d) to head (1b3e695).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1499   +/-   ##
=======================================
  Coverage   89.66%   89.66%           
=======================================
  Files          68       68           
  Lines        4869     4869           
  Branches      888      888           
=======================================
  Hits         4366     4366           
  Misses        485      485           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@jescalada jescalada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! How did you notice the failing imports and API usage mismatch here? Just want to make sure that there aren't any other similar issues before the v2 release. Related: #1484

We might need extra tests to cover CLI and plugin usage via imports to prevent them from failing on API/version changes.

@fabiovincenzi
Copy link
Copy Markdown
Contributor Author

@jescalada I found these by trying to build and run the CLI tests locally, and they all failed. The issues accumulated over time as the backend evolved (modules moved, exports changed, new API validations added) without updating the CLI, which wasn't being tested in CI, so we lost those bugs.
With #1500 CLI tests will run in CI, any future API/export changes that break the CLI will be caught immediately.

@jescalada
Copy link
Copy Markdown
Contributor

Sounds good! Will go ahead and merge this if there aren't any other pending issues.

@jescalada jescalada merged commit ba4f08e into finos:main Apr 13, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI package is broken, build fails and tests are not passing

2 participants