Skip to content

feat: bundle dependencies for strict network support#1395

Merged
jescalada merged 4 commits intofinos:mainfrom
dcoric:1344-remove-cdn
Feb 9, 2026
Merged

feat: bundle dependencies for strict network support#1395
jescalada merged 4 commits intofinos:mainfrom
dcoric:1344-remove-cdn

Conversation

@dcoric
Copy link
Copy Markdown
Contributor

@dcoric dcoric commented Feb 9, 2026

Description

Fixes #1344

Bundles external CDN dependencies (chartist, font-awesome, roboto, material-icons) into the application to support strict network environments where external CDN access is blocked.

Changes

  • [package.json]: Added chartist, font-awesome, @fontsource/roboto, and material-design-icons dependencies.
  • [index.html]: Removed external CDN <link> and <script> tags.
  • [src/index.tsx]: Imported necessary CSS files from local node_modules.
  • [dependency-review.yml]: Added WTFPL, Ubuntu-font-1.0 licenses

Here are the links to licenses that are added:

License Information

Verified licenses for all new dependencies:

Package License Validated
chartist MIT OR WTFPL
font-awesome OFL-1.1 AND MIT
@fontsource/roboto OFL-1.1
material-design-icons Apache-2.0

Verification

  • Verified no requests to cdn.jsdelivr.net, fonts.googleapis.com, or maxcdn.bootstrapcdn.com.
  • Confirmed icons and fonts render correctly via local build.

@dcoric dcoric requested a review from jescalada February 9, 2026 10:27
@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 9, 2026

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit f47f04f
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/6989e265124f170008e55a0c

@dcoric dcoric self-assigned this Feb 9, 2026
@dcoric dcoric requested a review from kriswest February 9, 2026 10:27
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.34%. Comparing base (784bfc4) to head (f47f04f).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1395   +/-   ##
=======================================
  Coverage   81.34%   81.34%           
=======================================
  Files          65       65           
  Lines        4648     4648           
  Branches      792      792           
=======================================
  Hits         3781     3781           
  Misses        852      852           
  Partials       15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@jescalada jescalada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The new licenses appear harmless 🙂

@kriswest

Copy link
Copy Markdown
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on - I wasn't able to get to it until today.

I think we can eliminate chartist (but happy to be proved wrong)

Comment thread src/index.tsx Outdated
Comment thread package.json Outdated
Comment thread .github/workflows/dependency-review.yml Outdated
Copy link
Copy Markdown
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - although I haven't checked the admin portal with a mkI eyeball yet. Will need to do so before the v2 release.

@jescalada jescalada merged commit 6fb63d0 into finos:main Feb 9, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove dependence on jsdelivr.net and possible unneeded dependency on chartist.js

3 participants