fix: the condition "types" here will never be used warning#1311
Merged
jescalada merged 2 commits intofinos:mainfrom Dec 6, 2025
Merged
fix: the condition "types" here will never be used warning#1311jescalada merged 2 commits intofinos:mainfrom
jescalada merged 2 commits intofinos:mainfrom
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1311 +/- ##
=======================================
Coverage 80.99% 80.99%
=======================================
Files 66 66
Lines 4499 4499
Branches 776 776
=======================================
Hits 3644 3644
Misses 840 840
Partials 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jescalada
approved these changes
Dec 6, 2025
Contributor
jescalada
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix Andy!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a warning I see when running the app or the tests.