Skip to content

fix: empty pagination #1274

Merged
jescalada merged 3 commits intofinos:mainfrom
andypols:fix-empty-pagination
Nov 7, 2025
Merged

fix: empty pagination #1274
jescalada merged 3 commits intofinos:mainfrom
andypols:fix-empty-pagination

Conversation

@andypols
Copy link
Copy Markdown
Contributor

@andypols andypols commented Nov 6, 2025

Summary

This PR fixes an issue with the pagination component where it incorrectly displayed Page 1 of 0 when no data was available.

Fix

  • Update to show Page 0 of 0 when empty.
  • Updated button styling to clearly indicate when buttons are disabled.
  • Center-aligned the pagination text between navigation buttons for better visual balance.

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 6, 2025

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 1b9a0ef
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/690cdce908b0350008b4a64d

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.36%. Comparing base (93704e6) to head (1b9a0ef).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1274   +/-   ##
=======================================
  Coverage   83.36%   83.36%           
=======================================
  Files          70       70           
  Lines        3005     3005           
  Branches      499      499           
=======================================
  Hits         2505     2505           
  Misses        397      397           
  Partials      103      103           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@andypols andypols changed the title Fix empty pagination fix: empty pagination Nov 6, 2025
@github-actions github-actions Bot added the fix label Nov 6, 2025
Copy link
Copy Markdown
Contributor

@jescalada jescalada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andypols LGTM, thanks for the contribution! 🚀

@jescalada jescalada merged commit df6406b into finos:main Nov 7, 2025
14 of 15 checks passed
@andypols andypols deleted the fix-empty-pagination branch November 8, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants