Skip to content

fix: Plugin loader tests#1262

Merged
jescalada merged 3 commits intofinos:mainfrom
jescalada:plugin-loader-test-fixes
Oct 30, 2025
Merged

fix: Plugin loader tests#1262
jescalada merged 3 commits intofinos:mainfrom
jescalada:plugin-loader-test-fixes

Conversation

@jescalada
Copy link
Copy Markdown
Contributor

@jescalada jescalada commented Oct 29, 2025

Fixes #1263.

Related: #1149

@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 29, 2025

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 7a28c43
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/690166ede793c10008c0fc7e

@github-actions github-actions Bot added the fix label Oct 29, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.36%. Comparing base (981d7b8) to head (7a28c43).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1262      +/-   ##
==========================================
+ Coverage   82.69%   83.36%   +0.66%     
==========================================
  Files          70       70              
  Lines        3005     3005              
  Branches      499      499              
==========================================
+ Hits         2485     2505      +20     
+ Misses        417      397      -20     
  Partials      103      103              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@coopernetes coopernetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for re-enabling these tests @jescalada . I'm curious what we did in the main branch that made the load-plugin library work again. Related to tsconfig changes perhaps?

f216ae6#diff-b55cdbef4907b7045f32cc5360d48d262cca5f94062e353089f189f4460039e0R12-R13

@jescalada jescalada marked this pull request as ready for review October 30, 2025 10:53
@jescalada
Copy link
Copy Markdown
Contributor Author

@coopernetes Thanks for the review! As you mentioned, the TS config plus proper package.json setup seems to fix that side. I'm not sure if this actually fixes the issue that you posted originally. I'd be super grateful if you could check this on your setup as it seems to be (mostly?) working on my side. I experimented with your patch and didn't notice any differences when adding the changes in this PR 🤔

I'll go ahead and merge this to update the Vitest refactor PR!

@jescalada jescalada merged commit a0e5bcc into finos:main Oct 30, 2025
15 checks passed
@jescalada jescalada linked an issue Nov 5, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix failing plugin loader tests Improve plugin loading functionality

2 participants