fix: Plugin loader tests#1262
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1262 +/- ##
==========================================
+ Coverage 82.69% 83.36% +0.66%
==========================================
Files 70 70
Lines 3005 3005
Branches 499 499
==========================================
+ Hits 2485 2505 +20
+ Misses 417 397 -20
Partials 103 103 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coopernetes
left a comment
There was a problem hiding this comment.
LGTM - thanks for re-enabling these tests @jescalada . I'm curious what we did in the main branch that made the load-plugin library work again. Related to tsconfig changes perhaps?
f216ae6#diff-b55cdbef4907b7045f32cc5360d48d262cca5f94062e353089f189f4460039e0R12-R13
|
@coopernetes Thanks for the review! As you mentioned, the TS config plus proper package.json setup seems to fix that side. I'm not sure if this actually fixes the issue that you posted originally. I'd be super grateful if you could check this on your setup as it seems to be (mostly?) working on my side. I experimented with your patch and didn't notice any differences when adding the changes in this PR 🤔 I'll go ahead and merge this to update the Vitest refactor PR! |
Fixes #1263.
Related: #1149