Skip to content

refactor: convert remaining UI files to TS#1256

Merged
jescalada merged 9 commits intofinos:mainfrom
jescalada:convert-remaining-js-files-to-ts
Oct 27, 2025
Merged

refactor: convert remaining UI files to TS#1256
jescalada merged 9 commits intofinos:mainfrom
jescalada:convert-remaining-js-files-to-ts

Conversation

@jescalada
Copy link
Copy Markdown
Contributor

@jescalada jescalada commented Oct 24, 2025

Fixes #1229.

Note that some UI files (old components, stylesheets) haven't been converted to TS. This is because we'll be removing those in #1106 to simplify UI dependencies and clean up the codebase.

@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 24, 2025

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 8c68e8c
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/68ff303afdfc530008840be6

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.64%. Comparing base (ae97d83) to head (8c68e8c).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1256   +/-   ##
=======================================
  Coverage   82.64%   82.64%           
=======================================
  Files          70       70           
  Lines        3007     3007           
  Branches      501      501           
=======================================
  Hits         2485     2485           
  Misses        419      419           
  Partials      103      103           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jescalada jescalada marked this pull request as ready for review October 24, 2025 02:04
@jescalada jescalada requested review from a team, andypols and fabiovincenzi October 27, 2025 02:32
@jescalada jescalada changed the title refactor: convert remaining js files to ts refactor: convert remaining UI files to TS Oct 27, 2025
Copy link
Copy Markdown
Contributor

@andypols andypols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jescalada
Copy link
Copy Markdown
Contributor Author

@andypols Thanks for the review!

@jescalada jescalada merged commit 6f56f15 into finos:main Oct 27, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert remaining ui/services to TS

2 participants