Skip to content

fix: the npm check-types failures#1254

Merged
jescalada merged 2 commits intofinos:mainfrom
andypols:fix-check-types
Oct 24, 2025
Merged

fix: the npm check-types failures#1254
jescalada merged 2 commits intofinos:mainfrom
andypols:fix-check-types

Conversation

@andypols
Copy link
Copy Markdown
Contributor

Summary

This PR resolves TypeScript errors encountered when running npm run check-types.

Fix

  • Removed the unused properties from the src/ui/views/RepoList/Components/Repositories.tsx component.

@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 23, 2025

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit fa3e58d
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/68fb782736edd00008573f3e

@github-actions github-actions Bot added the fix label Oct 23, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.64%. Comparing base (fd2bd57) to head (fa3e58d).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1254   +/-   ##
=======================================
  Coverage   82.64%   82.64%           
=======================================
  Files          70       70           
  Lines        3007     3007           
  Branches      501      501           
=======================================
  Hits         2485     2485           
  Misses        419      419           
  Partials      103      103           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@jescalada jescalada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the fix @andypols!

@jescalada jescalada merged commit fdd808d into finos:main Oct 24, 2025
14 checks passed
@andypols andypols deleted the fix-check-types branch October 24, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants