Skip to content

chore: deprecate github api baseUrl#1232

Merged
kriswest merged 11 commits intofinos:mainfrom
andypols:deprecate_github_api_baseurl
Oct 1, 2025
Merged

chore: deprecate github api baseUrl#1232
kriswest merged 11 commits intofinos:mainfrom
andypols:deprecate_github_api_baseurl

Conversation

@andypols
Copy link
Copy Markdown
Contributor

Summary

This PR addresses issue #1213

The github api baseUrl is not used in the codebase.

"api": {
    "github": {
      "baseUrl": "https://api.github.com"
    }
  },

Fix

It marks the github baseUrl as deprecated in the schema.

@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 29, 2025

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 3556da4
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/68dd4e24f3daff0007c8089d

@kriswest
Copy link
Copy Markdown
Contributor

Added a commit to fix a failing test and tighten the schema a hair more

@kriswest
Copy link
Copy Markdown
Contributor

...and another as the gitleaks config wasn't in the schema and additionalProperties: false started rejecting it

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.20%. Comparing base (292ecad) to head (3556da4).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1232   +/-   ##
=======================================
  Coverage   84.20%   84.20%           
=======================================
  Files          68       68           
  Lines        2938     2938           
  Branches      374      374           
=======================================
  Hits         2474     2474           
  Misses        404      404           
  Partials       60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@jescalada jescalada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I don't see any issues 🙂

@kriswest kriswest enabled auto-merge October 1, 2025 15:53
@kriswest kriswest merged commit cc8fac5 into finos:main Oct 1, 2025
14 checks passed
@andypols andypols deleted the deprecate_github_api_baseurl branch October 23, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants