chore: deprecate github api baseUrl#1232
Merged
kriswest merged 11 commits intofinos:mainfrom Oct 1, 2025
Merged
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Contributor
|
Added a commit to fix a failing test and tighten the schema a hair more |
Contributor
|
...and another as the gitleaks config wasn't in the schema and |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1232 +/- ##
=======================================
Coverage 84.20% 84.20%
=======================================
Files 68 68
Lines 2938 2938
Branches 374 374
=======================================
Hits 2474 2474
Misses 404 404
Partials 60 60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jescalada
approved these changes
Oct 1, 2025
Contributor
jescalada
left a comment
There was a problem hiding this comment.
LGTM, I don't see any issues 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issue #1213
The github api
baseUrlis not used in the codebase.Fix
It marks the github
baseUrlas deprecated in the schema.