fix: rename definitions/authentication in schema to make it more inutitive#1231
Merged
fix: rename definitions/authentication in schema to make it more inutitive#1231
Conversation
…itive There are two `authentication` elements in the config schema, which is confusing and can be made more intuitive by renaming one of them (as it is an element of the other) Signed-off-by: Kris West <kristopher.west@natwest.com>
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1231 +/- ##
=======================================
Coverage 84.20% 84.20%
=======================================
Files 68 68
Lines 2938 2938
Branches 374 374
=======================================
Hits 2474 2474
Misses 404 404
Partials 60 60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9d4186a to
15bc55d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two
authenticationelements in the config schema, one that defines an array of enabled authentication elements and the other which defines the elements themselves. This can be confusing when reading the schema and can be made more intuitive by renaming one of them (as it is an element of the other).