chore: add /healthcheck endpoint to the proxy#1197
Merged
jescalada merged 5 commits intofinos:mainfrom Sep 11, 2025
Merged
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
kriswest
requested changes
Sep 10, 2025
Contributor
kriswest
left a comment
There was a problem hiding this comment.
Seems fine - I think there's a typo to fix.
Contributor
|
Looks like there is a type error (that I don't think you introduced) failing the CI check. @jescalada @fabiovincenzi src/proxy/routes/index.ts may need a look... |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1197 +/- ##
==========================================
+ Coverage 83.71% 83.74% +0.03%
==========================================
Files 67 67
Lines 2886 2892 +6
Branches 365 366 +1
==========================================
+ Hits 2416 2422 +6
Misses 410 410
Partials 60 60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We’re deploying GitProxy on AWS behind an Application Load Balancer (ALB) listener that routes traffic to either the web app or the proxy. ALB target groups require a health-check path. The web app already exposes
/healthcheck, but the proxy does not.This PR adds a
/healthcheckendpoint to the proxy so the load balancer can verify it’s running, and includes a test.Changes
/healthcheckroute to the proxy returning 200 OK.test/testProxyRoute.test.js.