chore: add testing documentation and coverage checks#1147
Merged
jescalada merged 29 commits intofinos:mainfrom Sep 5, 2025
Merged
chore: add testing documentation and coverage checks#1147jescalada merged 29 commits intofinos:mainfrom
jescalada merged 29 commits intofinos:mainfrom
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1147 +/- ##
==========================================
+ Coverage 82.86% 83.22% +0.35%
==========================================
Files 66 66
Lines 2795 2795
Branches 332 332
==========================================
+ Hits 2316 2326 +10
+ Misses 431 423 -8
+ Partials 48 46 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 tasks
4 tasks
Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
dcoric
suggested changes
Aug 20, 2025
Contributor
dcoric
left a comment
There was a problem hiding this comment.
Very good in general, I just added a small nitpick.
kriswest
requested changes
Aug 21, 2025
Contributor
kriswest
left a comment
There was a problem hiding this comment.
Lots of good stuff here! I'd like to see resetting stubs emphasized as I lost a couple of hours to debugging confusing issues caused by stubs that were not reset.
Co-authored-by: Kris West <kristopher.west@natwest.com> Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
Contributor
|
Might be worth updating the template test and including sinon/proxyquire examples in it: https://github.com/finos/git-proxy/blob/main/test/1.test.js |
Contributor
Author
|
@kriswest Should be ready for a final look! |
kriswest
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the coverage checks mentioned in #1019, although it doesn't add any auto-merge on coverage attained (we still want maintainers to take a look at larger PRs and decide the right time to merge).
I've also added some documentation on how to implement unit, E2E and fuzz tests for new PRs.