-
Notifications
You must be signed in to change notification settings - Fork 86
FIP-0103: Removal of the ExtendSectorExpiration method from the miner actor #1690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the deprecated ExtendSectorExpiration method and all associated legacy handling, consolidating on the new ExtendSectorExpiration2 API.
- Eliminate all vestiges of the old
ExtendSectorExpirationmethod in actor code and tests - Update tests and utilities to only invoke
ExtendSectorExpiration2and drop version flags - Ensure test coverage remains equivalent by renaming and refactoring legacy test cases
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test_vm/tests/suite/extend_sectors_test.rs | Renamed and simplified the legacy extension test to use only v2 |
| integration_tests/src/tests/replica_update_test.rs | Updated method enum use to call the new v2 method ID |
| integration_tests/src/tests/extend_sectors_test.rs | Removed v1 branches and tests; all calls now target v2 |
| actors/miner/tests/util.rs | Dropped legacy helper and parameter types; versioned helper now only v2 |
| actors/miner/tests/extend_sector_expiration_test.rs | Stripped out all v1 test cases and updated remaining tests to v2 |
| actors/miner/src/lib.rs | Commented out deprecated enum variant and removed legacy handler code |
Comments suppressed due to low confidence (4)
test_vm/tests/suite/extend_sectors_test.rs:9
- [nitpick] The test name
extend_sector_with_dealsno longer distinguishes which extension version it covers. Consider renaming it toextend_sector_with_deals_extend2to make it clear that only the v2 API is exercised.
fn extend_sector_with_deals() {
actors/miner/tests/util.rs:2669
- [nitpick] This helper no longer handles multiple versions and always calls the v2 path. Consider renaming it (for example to
extend_sectors2_no_claims) to reflect that it invokes only the new API.
pub fn extend_sectors_versioned(
actors/miner/src/lib.rs:115
- [nitpick] The deprecated method enum variant is commented out but not marked as deprecated in the public API docs. Consider annotating it with
#[deprecated]or adding a clear comment in theMethodenum documentation to guide integrators.
//ExtendSectorExpiration = 8, // Deprecated
actors/miner/tests/extend_sector_expiration_test.rs:76
- [nitpick] The construction of
ExtendSectorExpiration2Paramswith a single-element vector is repeated across many tests. Consider extracting a small helper or builder function to reduce duplication and improve readability.
let params = ExtendSectorExpiration2Params {
ZenGround0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@ZenGround0 can i merge this PR? |
|
Yes, added it to the queue for you |
Removed deprecated
ExtendSectorExpirationas a new method already existExtendSectorExpiration2FIP-0103: https://github.com/filecoin-project/FIPs/blob/master/FIPS/fip-0103.md