Improve command line argument parsing #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #258
nodehas particular CLI usage patterns that are not supported byminimist. specifically,--inspectwhich has either no option or must include=.I've added specific support for
inspect&r/require. Unknown argument should be passed on to node.We now throw if we cannot identify the
scriptportion of the command line arguments. In the future we can instead list the command line arguments when this happens.The way this now works is we manually handle the
inspectoptions and remove them before passing the args off tominimist. We parse once withminimistto determine the location of thescriptand then parse again with the default values that we find in that script's directory.I'll release this with a major version bump as I'm not 100% certain I covered all the use cases out there.