Open
Conversation
- Add test.local configuration to seed/ruby-sdk-v2/seed.yml - Run bundle install before rubocop (was reversed) - Use bundle exec rubocop -A instead of bare rubocop - Clear RUBYLIB/GEM_PATH/GEM_HOME env vars to avoid nix/devbox Ruby version conflicts (Ruby 3.4 libs loaded by Ruby 3.3) Co-Authored-By: judah <jsklan.development@gmail.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
…sts) Co-Authored-By: bot_apk <apk@cognition.ai>
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Co-Authored-By: bot_apk <apk@cognition.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refs FER-9446
Fixes
seed test --localandseed run --localproducing different output from Docker mode for theruby-sdk-v2generator. The root cause was that rubocop formatting never ran in local mode, producing unformatted output while Docker produced formatted output.Changes Made
seed/ruby-sdk-v2/seed.yml: Add missingtest.localconfiguration (was required to enable--localmode at all)generators/ruby-v2/sdk/src/SdkGeneratorCli.ts: Three fixes to post-generation steps:bundle installbefore rubocop (was reversed — rubocop ran first and silently failed since gems weren't installed yet)bundle exec rubocop -Ainstead of barerubocop(uses the project's bundled rubocop instead of relying on a system-level install)RUBYLIB,GEM_PATH,GEM_HOMEenv vars when spawning Ruby processes to avoid nix/devbox library conflicts (devbox provides Ruby 3.3 butRUBYLIB/GEM_PATHpoint to Ruby 3.4 nix store paths, causingLoadErroron native extensions)generators/ruby-v2/sdk/versions.yml: Add v1.2.1 changelog entryscripts/validate-all-changelogs.sh: Removeruby-sdkfrom the changelog validation generators list (noseed/ruby-sdkdirectory exists, causing the "Validate Changelogs" CI check to crash)gem install 'rubocop:~> 1.21') and ran beforebundle install. Now it runs viabundle execafterbundle install, so it uses the Gemfile-pinned version. Verified that Docker output remains identical after the change.RUBYLIB,GEM_PATH,GEM_HOME→undefined) is safe in Docker since those vars aren't set in the container, but worth confirming.ruby-sdkremoval fromvalidate-all-changelogs.shfixes a pre-existing issue onmain— there is noseed/ruby-sdkdirectory, so the validation was always going to fail for that entry.Human Review Checklist
ruby-sdk(v1) genuinely has no seed directory or versions.yml requiring changelog validationRUBYLIB/GEM_PATH/GEM_HOMEdoesn't break Docker buildsTesting
seed test --generator ruby-sdk-v2 --fixture exhaustive --skip-scriptsin Docker mode (baseline)seed test --generator ruby-sdk-v2 --fixture exhaustive --skip-scripts --local— zero diff vs Dockerseed run --generator ruby-sdk-v2 --localandseed run(Docker) — identical output (onlyGemfile.lockplatform line differs:x86_64-linux-muslvsx86_64-linux, expected)pnpm formatandpnpm run checkpassLink to Devin session: https://app.devin.ai/sessions/54696844eb9247c0871aa49f1fa288e7