fix(python): unwrap alias types in pagination results type annotation#14508
Open
iamnamananand996 wants to merge 2 commits intomainfrom
Open
fix(python): unwrap alias types in pagination results type annotation#14508iamnamananand996 wants to merge 2 commits intomainfrom
iamnamananand996 wants to merge 2 commits intomainfrom
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
7edc948 to
7aa50c9
Compare
7aa50c9 to
26e1efd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a mypy type error in generated pagination endpoints when the results property type is a named alias to a list (e.g.,
AgreementsList = List[Agreement]).Discovered via fern-demo/docusign-python-sdk#4 where mypy reported:
Changes Made
All changes below were independently merged to
mainas v5.3.1 before this PR could be merged. The branch is now empty.endpoint_function_generator.py: Extended_unwrap_container_typesto handlenamedtype references that resolve to alias types. When the pagination results property is a named alias to a list/set, the method now resolves the alias declaration, checks if its resolved type is a container, and recursively unwraps it — producingSyncPager[Agreement, ...]instead ofSyncPager[AgreementsList, ...].versions.yml: Added changelog entry for v5.3.1.Testing
seed test --generator python-sdk --fixture pagination— all 3 configurations pass with no generated code changesruff,ruff-format, etc.)pnpm run checkpassesReviewer Checklist
main(v5.3.1)maincorrectly handles chained aliases (not just one level of resolution)Link to Devin session: https://app.devin.ai/sessions/c854539c0cc24a0d9627ebf03398dc1c
Requested by: @iamnamananand996