Closed
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
… methods Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…ia runtime helpers) Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…n system The Postman generator uses @fern-fern/ir-sdk@53.9.0 which doesn't have v66 types. The migration system automatically converts v66 IR to the older format before passing it to the generator, so no code changes are needed. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…d missing visitor variants Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrades the Postman generator to IR v66, which compresses the
Nametype into aNameOrStringunion (plain string or fullNameobject). All generator source code is updated to use runtime helpers (getWireValue(),getOriginalName(),CaseConverter) for transparent handling of both compressed and uncompressed name formats.Changes Made
v66 IR Handling
.wireValueaccesses withgetWireValue()helper (auth headers, query params, example headers).originalNameaccesses withgetOriginalName()helper (error names, subpackage names, endpoint names, path params, API name).camelCase.unsafeName/.screamingSnakeCase.unsafeNameaccesses withCaseConvertermethodsCaseConverterinstances inauth.tsandAbstractGeneratedRequest.tsNew IR Union Variants
inferredauth scheme handler inauth.tsandconvertToPostmanCollection.tsbytesresponse body handler inconvertExampleEndpointCall.tsheadHTTP method handler inAbstractGeneratedRequest.ts(mapped to GET — PostmanMethod enum lacks HEAD)filesystempublish target handler inwritePostmanCollection.tspublishConfig.targetbefore accessing postman-specific fieldsVersion & Migration
0.7.0-rc.0entry togenerators/postman/versions.ymlwithirVersion: 66POSTMAN → "0.7.0-rc.0"inmigrateFromV66ToV65.tsseed/postman/seed.ymlirVersion fromv53tov66Testing
irVersion: v66Human Review Checklist
migrateFromV66ToV65.ts.wireValue/.originalName/ casing accesses migrated to helper functions@fern-fern/ir-sdkchanged to66.0.0-alpha.1, butpackage.jsonwas reverted to53.9.0. The lock file may need to be regenerated (pnpm install) to stay in sync.AbstractGeneratedRequest.ts:102):PostmanMethodenum lacks HEAD, soheadis mapped toPostmanMethod.Getas a workaround. Verify this is acceptable or if the Postman SDK should be extended.0.6.1 → 0.7.0-rc.0follows the correct convention for this generatorLink to Devin session: https://app.devin.ai/sessions/1947204928ba4bfe9b663dfe828ac3d7
Requested by: @Swimburger