Add forwarding attachments#420
Merged
Merged
Conversation
Contributor
kapi2289
commented
Apr 18, 2019
madsmtm
reviewed
Apr 21, 2019
madsmtm
approved these changes
Apr 22, 2019
Member
madsmtm
left a comment
There was a problem hiding this comment.
LGMT so far 👍. Are you ready to merge this, or do you want to add an attribute on Message that says whether or not it's a forwarded message? (This can be done by checking if "source:chat:forward" is in the tags list)
madsmtm
requested changes
Apr 24, 2019
madsmtm
approved these changes
Apr 25, 2019
madsmtm
added a commit
that referenced
this pull request
Jun 23, 2019
- Removed / privatized a lot of undocumented functionality, which might break some users application if they were relying on those (hence the minor version bump). See #432 for further reasoning - Add `Client.forwardAttachment` and `Message.forwarded` attribute, see #420 - Fix parsing subattachments with no target, see #412 - Lots of other refactoring, aka. work on the transition towards v2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.