fix: hide tab shortcut hints when Shift is held (Cmd+Shift+5 screenshots)#4214
Merged
ComputelessComputer merged 1 commit intomainfrom Feb 24, 2026
Conversation
…ing Cmd+Shift+5 screenshots) Co-Authored-By: John <john@hyprnote.com>
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When taking macOS screenshots with
Cmd+Shift+5, the Cmd key triggersuseCmdKeyPressed, causing⌘ 1,⌘ K, etc. shortcut badges to appear in tabs and search — and get captured in the screenshot.This fix suppresses the shortcut hints whenever Shift is held alongside Cmd (
setIsCmdPressed(!e.shiftKey)), and restores them if Shift is released while Cmd is still held.Review & Testing Checklist for Human
Cmd+Shift+5and confirm shortcut badges do NOT appear in tabs/searchCmd— shortcut badges should still appear as before⌘ Ksearch hint: Confirm the search bar shortcut hint also respects this behaviorNotes