-
Notifications
You must be signed in to change notification settings - Fork 10
feat: migrate to Ruby 3.3 w/ GitHub Actions automation #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
janpio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me.
@joshdholtz is probably the one with the Dockerhub credentials.
|
Thanks! I'm waking up the Slack Team used in the past to try and reach out to those with permission to things more easily - I can only imagine the huge backlog of GitHub pings there are. |
| ENV UV_PYTHON_INSTALL_DIR=/opt/uv/python | ||
|
|
||
| # Install pip & pipenv | ||
| RUN wget --quiet https://bootstrap.pypa.io/get-pip.py -O /tmp/get-pip.py > /dev/null 2>&1 && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't uv supposed to replace pip?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I figured I needed both in meantime to do a few "hops" among fastlane/docs so everything didn't go at once.
tldr
testing
nerdy
for admin of DockerHub
*DOCKERHUB_USERNAME- username for DockerHubDOCKERHUB_TOKEN- PAT for DockerHub needs Read/Write.