Skip to content

Updates for fastify v5 - #107

Merged
jsumners merged 2 commits into
fastify:mainfrom
nrayburn-tech:initial-v4-set
Nov 1, 2023
Merged

Updates for fastify v5#107
jsumners merged 2 commits into
fastify:mainfrom
nrayburn-tech:initial-v4-set

Conversation

@nrayburn-tech

@nrayburn-tech nrayburn-tech commented Nov 1, 2023

Copy link
Copy Markdown
Contributor

Drop node <= 16 from workflows
Add node 21 to benchmark-pr
Add node 21 to ci-package-manager for yarn

Fixes #106, #92.

Checklist

Add node 21 to benchmark-pr
Add node 21 to ci-package-manager for yarn

@jsumners jsumners left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jsumners
jsumners merged commit 29329a1 into fastify:main Nov 1, 2023
@jsumners

jsumners commented Nov 1, 2023

Copy link
Copy Markdown
Member

The v4 tag has been created.

@mcollina

mcollina commented Nov 1, 2023

Copy link
Copy Markdown
Member

Let's hope this does not get auto-updated across the entire fleet, otherwise it would be a nightmare to revert.

@jsumners

jsumners commented Nov 1, 2023

Copy link
Copy Markdown
Member

It shouldn't. But what in the actual eff Dependabot? fastify/releasify#283

@Fdawgs I believe you have setup the majority of the Dependabot stuff. Do you know why it would automatically update the major versions of workflows?

@Fdawgs

Fdawgs commented Nov 1, 2023

Copy link
Copy Markdown
Member

@mcollina

mcollina commented Nov 1, 2023

Copy link
Copy Markdown
Member

@Fdawgs would this land automatically then?

@Fdawgs

Fdawgs commented Nov 1, 2023

Copy link
Copy Markdown
Member

@Fdawgs would this land automatically then?

Unfortunately, yes. Can see it making its way through all the reps now. 😵‍💫

@jsumners

jsumners commented Nov 1, 2023

Copy link
Copy Markdown
Member

We really should not be updating at least our own workflows's major version automatically. The whole point of the versioning, particularly in this repo, is to indicate breaking changes in the workflow.

@jsumners

jsumners commented Nov 1, 2023

Copy link
Copy Markdown
Member

How do we stop the linked tool from updating all of our repos automatically for this?

@jsumners

jsumners commented Nov 1, 2023

Copy link
Copy Markdown
Member

@nrayburn-tech I have removed the v4 tag for right now. To continue your work, use the git SHA. I will restore the v4 tag once we have fixed the above discussed problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Create a v4 set

4 participants