Skip to content

use tap instead of ava, 100% test coverage, move types to types folder, activate linting in ci-pipeline - #65

Merged
mcollina merged 6 commits into
fastify:masterfrom
Uzlopak:refactor
Aug 18, 2022
Merged

use tap instead of ava, 100% test coverage, move types to types folder, activate linting in ci-pipeline#65
mcollina merged 6 commits into
fastify:masterfrom
Uzlopak:refactor

Conversation

@Uzlopak

@Uzlopak Uzlopak commented Aug 17, 2022

Copy link
Copy Markdown
Contributor

Checklist

@Fdawgs Fdawgs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know enough about tap to approve that bit, but the rest LGTM.

@Uzlopak

Uzlopak commented Aug 18, 2022

Copy link
Copy Markdown
Contributor Author

The only big change of the tap conversion was that ava has this test.serial.cb functionality, which basically spawns a new process for the unit test. This is relevant because we are listening in those two tests on process-events. If the tests run in parallel, then the tests fail, because we are listening on all events.

Tap does not have this convenient way to run subtests in an own process. But you just have to extract the subtest to a separate suite and it runs in a separate process.

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
mcollina merged commit 6090363 into fastify:master Aug 18, 2022
@Uzlopak
Uzlopak deleted the refactor branch August 18, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants