migrate to class - #271
Conversation
| // TODO change this to use the header getter | ||
| const regex = new RegExp('\\r\\n' + name + ': ([^\\r]*)\\r\\n') | ||
| const [, value] = this._header.match(regex) || [] | ||
| // const value = this.getHeader(name) | ||
| if (value) { | ||
| this._lightMyRequest.headers[name.toLowerCase()] = value |
There was a problem hiding this comment.
will the unit tests pass if you use the header getter?
There was a problem hiding this comment.
What do you mean, this function is same as original
There was a problem hiding this comment.
Do not pass, these headers 'Data', 'Connection', 'Transfer-Encoding' do not exist
|
@jsumners, Can you explain your negative attitude? |
|
@jsumners I'm not mentioning bun in this PR (since not all issues are resolved) |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
migrate to class syntax (Chain, request, response)
copied class from #252
but without changing the logic in
lib/do-inject.js(doInject) (to resolve Test Fastify Integration)Checklist
npm run testandnpm run benchmarkand the Code of conduct