Expose named export (fix TypeScript>=4.8 with native ESM)#207
Expose named export (fix TypeScript>=4.8 with native ESM)#207aboutlo merged 3 commits intofastify:masterfrom greguz:feature/ts-esm
Conversation
Pull Request Test Coverage Report for Build 4055827173Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
|
@climba03003 |
climba03003
left a comment
There was a problem hiding this comment.
I wouldn't block for a named export with shorten name.
Co-authored-by: KaKa <climba03003@gmail.com>
|
Is this a real life? i will finally be able to update TS? LGTM |
|
I've noticed a couple of things:
Also I've just created a pure-ESM version of this project under the name fluent-json-schema-es where you can use the By doing that I saw that a double-module package (bot ESM and CJS code inside the same package) could potentially fix the issue with TypeScript entirely. I suggest What are your thoughts about It? I will be happy to make this change and deprecate |
Sure, please open a separate PR. 😄
See fastify/fastify#2847 for ESM discussion. |
|
when's release? |
Checklist
npm run testand the Code of conduct