This repository was archived by the owner on Jan 13, 2022. It is now read-only.
[4.0] Fix for multidimensional params support#386
Merged
gfosco merged 1 commit intofacebookarchive:4.0-devfrom Apr 2, 2015
Merged
[4.0] Fix for multidimensional params support#386gfosco merged 1 commit intofacebookarchive:4.0-devfrom
gfosco merged 1 commit intofacebookarchive:4.0-devfrom
Conversation
gfosco
added a commit
that referenced
this pull request
Apr 2, 2015
[4.0] Fix for multidimensional params support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went in to debug #383 and found that the 4.0 tests were failing out of the box. This PR:
This is just a hack to get multidimensional param support without rewriting all the HTTP client stuffs like we did in 4.1. :)