Skip to content
This repository was archived by the owner on Jan 13, 2022. It is now read-only.

At least one endpoint allows for the type parameter to be set in the URL...#242

Merged
gfosco merged 1 commit intofacebookarchive:4.0-devfrom
asolberg:next_request_type_path_conflict
Sep 23, 2014
Merged

At least one endpoint allows for the type parameter to be set in the URL...#242
gfosco merged 1 commit intofacebookarchive:4.0-devfrom
asolberg:next_request_type_path_conflict

Conversation

@asolberg
Copy link
Copy Markdown

... (paginated responses for example). If we're making a request to a URL with 'type' already specified, we don't need to include it as a query parameter

…URL (paginated responses for example). If we're making a request to a URL with 'type' already specified, we don't need to include it as a query parameter
@asolberg
Copy link
Copy Markdown
Author

@gfosco - You asked me to rebase this against the latest, so I did. All the tests are passing except
FacebookPageTabHelperTest::testPageDataCanBeAccessed
Failed asserting that false is true.

But I don't think its related to change - that test was failing even before my commit.

gfosco added a commit that referenced this pull request Sep 23, 2014
At least one endpoint allows for the type parameter to be set in the URL...
@gfosco gfosco merged commit 906c5ef into facebookarchive:4.0-dev Sep 23, 2014
@gfosco
Copy link
Copy Markdown
Contributor

gfosco commented Sep 23, 2014

If this is also necessary in the 4.1 branch, I welcome a PR for that too. Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants