Merged
Conversation
Contributor
|
Created a phabricator view of this PR. Will follow-up with comments. @adamretter: it seems I cannot assign you as the author of D54279 directly, can you try commando that diff and see if it works? |
…th native references
… java.lang.AutoCloseable
Contributor
|
LGTM. Thanks for the contribution! |
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARM (Automatic Resource Management)
The purpose of these commits is to move away from relying on the Garbage Collector to call
finalizeon the various Objects of the Rocks Java API in order to free the underlying C++ objects and memory. Instead we will require users of the Java API to explicitly free the Java Objects, by callingclose; To this end we have implementedjava.lang.AutoCloseablethroughout the API, which allows the user to make use of Java 7'stry-with-resources.Along the way, improvements have also been made around the Java/C++ JNI bridge with respect to object creation/initialization and destruction. These changes require thorough testing as the synchronization of object cleanup has been changed.