[Fiber] Fix formatting of invalid element invariant#8908
Merged
acdlite merged 1 commit intofacebook:masterfrom Feb 1, 2017
Merged
[Fiber] Fix formatting of invalid element invariant#8908acdlite merged 1 commit intofacebook:masterfrom
acdlite merged 1 commit intofacebook:masterfrom
Conversation
Message is slightly different for functional and class components.
sophiebits
approved these changes
Jan 31, 2017
gaearon
approved these changes
Jan 31, 2017
Collaborator
gaearon
left a comment
There was a problem hiding this comment.
Looks fine to me. We'll need to check if createWarning.js internally depends on this message and change it if it's there too.
Collaborator
|
This is an invariant, so it's okay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Message is slightly different for functional and class components.