Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues from PR #7360.
First step toward repurposing the recently-added
ReactFiberErrorLoggeras a more genericReactDevInterface. I am going to abandon this PR (for now) due to time constraints but I'd like to pick it back up in the future.The basic idea is:
Reactprovides a default, renderer-agnostic implementation that logs errors and warnings to the console. (This can help with things like Jest tests.)This PR is half-baked but it's here for posterity. 😄
UI treatment ideas for DOM
Team feedback