Read "current" props from the node instead of the Fiber#8839
Merged
sebmarkbage merged 1 commit intofacebook:masterfrom Jan 21, 2017
Merged
Read "current" props from the node instead of the Fiber#8839sebmarkbage merged 1 commit intofacebook:masterfrom
sebmarkbage merged 1 commit intofacebook:masterfrom
Conversation
sebmarkbage
commented
Jan 21, 2017
| ); | ||
| const props = EventPluginUtils.getFiberCurrentPropsFromNode( | ||
| internalInstance.stateNode | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
This is the only change. The rest is renames.
It's not just events that read the current props. Controlled components do as well. Since we're no longer updating the Fiber pointer during updates we have to instead read from the node props to get the current props. Since this method is no longer just used for events I renamed it.
71afc24 to
b1eb9e8
Compare
sophiebits
approved these changes
Jan 21, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes controlled components after I broke them in. #8607
It's not just events that read the current props. Controlled components do as well. Since we're no longer updating the Fiber pointer during updates we have to instead read from the node props to get the current props.
Since this method is no longer just used for events I renamed it.