Add test for componentDidUpdate with a bailout in the middle#8525
Merged
sebmarkbage merged 1 commit intofacebook:masterfrom Dec 7, 2016
Merged
Add test for componentDidUpdate with a bailout in the middle#8525sebmarkbage merged 1 commit intofacebook:masterfrom
sebmarkbage merged 1 commit intofacebook:masterfrom
Conversation
This is one of the cases where Fiber diverges.
Collaborator
|
@acdlite is going to fix this so stack is the same |
Contributor
Author
|
no not this one. That's another one. |
sophiebits
reviewed
Dec 8, 2016
| // We expect the same thing to happen if we bail out in the middle. | ||
| expect(ops).toEqual( | ||
| ReactDOMFeatureFlags.useFiber ? | ||
| [ |
Collaborator
There was a problem hiding this comment.
Lint fails for indentation here. ¯\_(ツ)_/¯
laurinenas
pushed a commit
to laurinenas/react
that referenced
this pull request
May 28, 2018
…k#8525) This is one of the cases where Fiber diverges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one of the cases where Fiber diverges.