[Fiber] Swap .child and .stateNode in coroutines#8414
Closed
sebmarkbage wants to merge 1 commit intofacebook:masterfrom
Closed
[Fiber] Swap .child and .stateNode in coroutines#8414sebmarkbage wants to merge 1 commit intofacebook:masterfrom
sebmarkbage wants to merge 1 commit intofacebook:masterfrom
Conversation
67a2cc8 to
bb2144d
Compare
1972b8f to
c1a7d63
Compare
Contributor
Author
|
I think this is ready to merge now. Not sure why I didn't just finish this. Will build some follow ups on top of this. |
It is slightly more useful this way because when we want to find host nodes we typically want to do so in the second phase. That's the real tree where as the first phase is more of a virtual part of the tree.
c1a7d63 to
1293ec3
Compare
Contributor
Author
|
Already landed in another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from #8406