[Fiber] [Do not merge: failing] Add failing tests for coroutines#8413
Closed
gaearon wants to merge 1 commit intofacebook:masterfrom
Closed
[Fiber] [Do not merge: failing] Add failing tests for coroutines#8413gaearon wants to merge 1 commit intofacebook:masterfrom
gaearon wants to merge 1 commit intofacebook:masterfrom
Conversation
gaearon
commented
Nov 24, 2016
| ]); | ||
| }); | ||
|
|
||
| it('should unmount a composite in a coroutine', () => { |
There are a few different issues: * Updates result in unnecessary duplicate placements because it can't find the current fiber for continuations. * When run together, coroutine update and unmounting tests appear to lock down in an infinite loop. They don't freeze in isolation. I don't have a solution for this but just leaving it for future fixes.
80fbcc1 to
f885816
Compare
Contributor
|
I think we already landed this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a few different issues:
I don't have a solution for this but just leaving it for future fixes.