Conversation
sebmarkbage
approved these changes
Nov 24, 2016
Contributor
sebmarkbage
left a comment
There was a problem hiding this comment.
Guessing you'll need to fix Flow.
Collaborator
|
What does this fix? Is there a failing test we need to add? |
Collaborator
Author
|
Two bugs: When the immediate parent isn't a context provider but an ancestor is, or if a layer has no context providers but does have context from its parent and then it creates a sublayer. I'll probably add tests but hopefully we can delete this code soon. |
acusti
pushed a commit
to brandcast/react
that referenced
this pull request
Mar 15, 2017
laurinenas
pushed a commit
to laurinenas/react
that referenced
this pull request
May 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.