Use explicit $.ajax dataType and add error callback #733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/docs/tutorial.md
Outdated
petehunt
added a commit
that referenced
this pull request
Dec 29, 2013
Use explicit $.ajax dataType and add error callback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working through the tutorial, I ran into a perplexing problem caused by my
.jsonfile being served astext/htmlinstead ofapplication/json:https://ludios.org/tmp/react-json-wrong-mime-type_.png
An explicit
dataTypeargument makes the server's incorrectContent-Typeirrelevant.After I specified the json dataType, my application silently failed to load comments because my
.jsonfile had a trailing semicolon. This PR adds an error callback that logs errors to the console..toString()is necessary to print the exception message in Chrome 31 and Firefox 26.