Skip to content

Conversation

@syranide
Copy link
Contributor

Ever so slightly more like your internal FB-linting.

vjeux added a commit that referenced this pull request Dec 28, 2013
Added max line length = 80 for jshint
@vjeux vjeux merged commit fdf6491 into facebook:master Dec 28, 2013
@syranide syranide deleted the lint80 branch December 28, 2013 12:30
@zpao
Copy link
Member

zpao commented Jan 3, 2014

I might revert this, but haven't decided. The 80 chars is a strong suggestion, but I mostly trust humans to break the rules where it makes sense. That URL should remain on a single line so it's copy-pastable.

That said, we've come back multiple times with "make this fit in 80" so perhaps it makes sense to have but make it a warning but not fail lint (I'm not sure that's even possible)

@syranide
Copy link
Contributor Author

syranide commented Jan 3, 2014

@zpao Feel free! I suggested it only becuse make this fit in 80 and it's hard to check otherwise The problem with keeping lines longer than that in the rep is that jshint will complain for all files, all the time, and it didn't seem to be easily fixable. So if there ends up being a lot of URLs, the lint will become useless again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants