Skip to content

Conversation

@tacryt-socryp
Copy link

Fixes issue #655

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind adding a comment that this is for OG <meta> tags?

@zpao
Copy link
Member

zpao commented Dec 22, 2013

And you already signed the CLA. Awesome :)

Let's get the comment in there and then this is good to go. If you want, feel free to amend the current commit and push -f, then the pull request will be updated automatically without multiple commits.

@tacryt-socryp
Copy link
Author

How would I go about rolling back the previous two and adding them as a single commit?

@sophiebits
Copy link
Collaborator

If you run git rebase -i HEAD~2 then you'll be given an editor with the last two commits -- in this case you probably want to replace the second "pick" with "fixup" or just "f" to combine them.

@tacryt-socryp
Copy link
Author

Thank you!

@zpao
Copy link
Member

zpao commented Dec 23, 2013

Thanks a lot Logan! I'm going to be out for most of the next 2 weeks, but if you want to pick up some more issues, we'd appreciate the help :) You might be able to get some more immediate assistance in the IRC channel (#reactjs on freenode).

zpao added a commit that referenced this pull request Dec 23, 2013
Added property attribute to non-standard attributes
@zpao zpao merged commit 1783e54 into facebook:master Dec 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants