Skip to content

Conversation

@jyash97
Copy link
Contributor

@jyash97 jyash97 commented Jul 8, 2020

Summary

When doing profiling HOC name is not displayed in Chart. We show HOC name in the Components tab.

Test Plan

Ran ->

From root: yarn build-devtools -> For building devtools specific bundles
From react-devtools-inline: yarn start -> For starting up app to test with inline package
From react-devtools-shell: yarn start

Test App ->

Updated the react-devtools-inline app:

Created a HOC component and wrapped ListItem twice. Testing video: https://www.loom.com/share/df805218e51d414abf68ea8e3e585cb9

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 8, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2ba473b:

Sandbox Source
React Configuration

@sizebot
Copy link

sizebot commented Jul 8, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 2ba473b

@sizebot
Copy link

sizebot commented Jul 8, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 2ba473b

@bvaughn
Copy link
Contributor

bvaughn commented Jul 10, 2020

Thanks a bunch for this PR! 🙇

Looks like another one was opened around the same time, #19283. It has a visual treatment that I'm slightly more a fan of, and passes CI, so I'm going to move forward with it.

But thank you again.

@bvaughn bvaughn closed this Jul 10, 2020
@jyash97
Copy link
Contributor Author

jyash97 commented Jul 10, 2020

Thanks for the review. Really Appreciate :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants