Skip to content

Re-enabled DebugTracing feature for old reconciler fork #19142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bvaughn merged 1 commit into from
Jun 16, 2020
Merged

Re-enabled DebugTracing feature for old reconciler fork #19142

bvaughn merged 1 commit into from
Jun 16, 2020

Conversation

@bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Jun 16, 2020 •
edited
Loading

It was temporarily removed by @sebmarkbage via PR #18697. Newly re-added tracing is simplified, since the lane(s) data type does not require the (lossy) conversion between priority and expiration time values.

@sebmarkbage mentioned that he removed this because it might get in the way of his planned discrete/sync refactor. I'm not sure if that concern still applies, but just in case- I have only re-added it to the old reconciler fork for now.

For example, this code:

class Example extends React.Component {
  state = {didMount: false};
  componentDidMount() {
    this.setState({didMount: true});
  }
  render() {
    return null;
  }
}

const root = createRoot(container);
root.render(
  <React.unstable_DebugTracingMode>
    <Example />
  </React.unstable_DebugTracingMode>,
);

Would produce this debug trace:

▼ ⚛️ commit (0b000000000000000000001000000000)
| ▼ ⚛️ layout effects (0b000000000000000000001000000000)
| | ⚛️ Example updated state (0b000000000000000000000000000001)

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jun 16, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 16, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e9fcc79:

Sandbox Source
cool-tu-h3oyi Configuration

@bvaughn
Copy link
Contributor Author

bvaughn commented Jun 16, 2020

@sebmarkbage if you're no longer concerned about this, given the simplified lanes implementation, let me know and I'll re-add to the new fork as well.

@sizebot
Copy link

sizebot commented Jun 16, 2020 •
edited
Loading

Details of bundled changes.

Comparing: d4fc2c1...e9fcc79

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactART-prod.js 0.0% -0.0% 247.36 KB 247.36 KB 43.74 KB 43.73 KB FB_WWW_PROD
react-art.development.js -0.0% -0.0% 663.74 KB 663.51 KB 141.11 KB 141.07 KB UMD_DEV
react-art.development.js -0.0% -0.0% 566.27 KB 566.04 KB 123.35 KB 123.3 KB NODE_DEV
react-art.production.min.js 0.0% -0.0% 74.42 KB 74.42 KB 23.03 KB 23.02 KB NODE_PROD
ReactART-dev.js +1.0% +0.9% 620.28 KB 626.24 KB 132.03 KB 133.19 KB FB_WWW_DEV

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js -0.0% -0.0% 892.73 KB 892.49 KB 204.25 KB 204.2 KB NODE_DEV
react-dom-server.node.development.js 0.0% -0.0% 136.74 KB 136.74 KB 36.38 KB 36.38 KB NODE_DEV
react-dom.production.min.js 0.0% -0.0% 122.3 KB 122.3 KB 39.03 KB 39.03 KB NODE_PROD
react-dom-server.browser.development.js 0.0% -0.0% 142.79 KB 142.79 KB 36.58 KB 36.58 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 13.17 KB 13.17 KB 4.89 KB 4.89 KB UMD_PROD
ReactDOMTesting-dev.js -0.0% -0.0% 978.85 KB 978.62 KB 219.83 KB 219.78 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% -0.0% 70.08 KB 70.08 KB 19.59 KB 19.59 KB NODE_DEV
ReactDOMTesting-prod.js 0.0% -0.0% 406.84 KB 406.84 KB 76.47 KB 76.47 KB FB_WWW_PROD
react-dom-test-utils.production.min.js 0.0% -0.0% 13.05 KB 13.05 KB 4.8 KB 4.8 KB NODE_PROD
react-dom.development.js -0.0% -0.0% 938.25 KB 938.01 KB 206.9 KB 206.86 KB UMD_DEV
react-dom.production.min.js 0.0% -0.0% 122.16 KB 122.16 KB 39.92 KB 39.92 KB UMD_PROD
react-dom.profiling.min.js 0.0% -0.0% 126.07 KB 126.07 KB 41.09 KB 41.08 KB UMD_PROFILING
ReactDOMForked-dev.js -0.0% -0.0% 998.02 KB 998.02 KB 222.93 KB 222.92 KB FB_WWW_DEV
react-dom.profiling.min.js 0.0% -0.0% 126.38 KB 126.38 KB 40.25 KB 40.25 KB NODE_PROFILING
ReactDOM-dev.js +0.6% +0.5% 999.16 KB 1005.13 KB 223.04 KB 224.2 KB FB_WWW_DEV
ReactDOM-prod.js 0.0% -0.0% 406.99 KB 406.99 KB 75.25 KB 75.25 KB FB_WWW_PROD
react-dom-server.browser.development.js 0.0% -0.0% 135.46 KB 135.46 KB 36.13 KB 36.12 KB NODE_DEV
ReactDOM-profiling.js 0.0% -0.0% 417.59 KB 417.59 KB 77.03 KB 77.03 KB FB_WWW_PROFILING
react-dom-server.browser.production.min.js 0.0% -0.0% 19.8 KB 19.8 KB 7.43 KB 7.43 KB NODE_PROD
ReactDOMServer-dev.js 0.0% -0.0% 146.54 KB 146.54 KB 37.26 KB 37.26 KB FB_WWW_DEV
ReactDOMServer-prod.js 0.0% -0.0% 47.44 KB 47.44 KB 11.11 KB 11.11 KB FB_WWW_PROD

ReactDOM: size: 0.0%, gzip: -0.0%

Size changes (stable)

Generated by 🚫 dangerJS against e9fcc79

@sizebot
Copy link

sizebot commented Jun 16, 2020 •
edited
Loading

Details of bundled changes.

Comparing: d4fc2c1...e9fcc79

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactART-prod.js 0.0% -0.0% 240.22 KB 240.22 KB 42.46 KB 42.45 KB FB_WWW_PROD
react-art.development.js -0.0% -0.0% 685.9 KB 685.67 KB 145.19 KB 145.15 KB UMD_DEV
react-art.production.min.js 0.0% -0.0% 112.35 KB 112.35 KB 34.75 KB 34.75 KB UMD_PROD
react-art.development.js -0.0% -0.0% 587.52 KB 587.29 KB 127.39 KB 127.35 KB NODE_DEV
react-art.production.min.js 0.0% -0.0% 77.31 KB 77.31 KB 23.89 KB 23.89 KB NODE_PROD
ReactART-dev.js +1.0% +0.9% 610.26 KB 616.23 KB 130 KB 131.15 KB FB_WWW_DEV

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js -0.0% -0.0% 923.16 KB 922.92 KB 209.82 KB 209.77 KB NODE_DEV
ReactDOMForked-prod.js 0.0% -0.0% 395.61 KB 395.61 KB 73.41 KB 73.4 KB FB_WWW_PROD
react-dom-server.node.development.js 0.0% -0.0% 138.25 KB 138.25 KB 36.58 KB 36.58 KB NODE_DEV
react-dom.production.min.js 0.0% -0.0% 126.77 KB 126.77 KB 40.33 KB 40.33 KB NODE_PROD
ReactDOMForked-profiling.js 0.0% -0.0% 406.15 KB 406.15 KB 75.17 KB 75.16 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% -0.0% 144.38 KB 144.38 KB 36.78 KB 36.78 KB UMD_DEV
react-dom-server.node.production.min.js 0.0% -0.0% 20.68 KB 20.68 KB 7.66 KB 7.66 KB NODE_PROD
react-dom-test-utils.production.min.js 0.0% -0.0% 13.18 KB 13.18 KB 4.9 KB 4.9 KB UMD_PROD
ReactDOMTesting-dev.js -0.0% -0.0% 953.06 KB 952.82 KB 214.18 KB 214.12 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% -0.0% 70.09 KB 70.09 KB 19.6 KB 19.6 KB NODE_DEV
ReactDOMTesting-prod.js 0.0% -0.0% 394.87 KB 394.87 KB 74.51 KB 74.51 KB FB_WWW_PROD
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 5.61 KB 5.61 KB 1.86 KB 1.86 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 13.06 KB 13.06 KB 4.81 KB 4.8 KB NODE_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.2% 5.36 KB 5.36 KB 1.8 KB 1.8 KB UMD_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% -0.1% 1.17 KB 1.17 KB 667 B 666 B NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.1% 1.2 KB 1.2 KB 705 B 704 B UMD_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 4.87 KB 4.87 KB 1.7 KB 1.7 KB NODE_DEV
react-dom.development.js -0.0% -0.0% 970.03 KB 969.8 KB 212.58 KB 212.53 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.2% 1.01 KB 1.01 KB 616 B 615 B NODE_PROD
react-dom.production.min.js 0.0% -0.0% 126.55 KB 126.55 KB 41.2 KB 41.2 KB UMD_PROD
ReactDOMForked-dev.js -0.0% -0.0% 972.47 KB 972.47 KB 217.11 KB 217.11 KB FB_WWW_DEV
react-dom.profiling.min.js 0.0% -0.0% 130.9 KB 130.9 KB 41.51 KB 41.51 KB NODE_PROFILING
ReactDOM-dev.js +0.6% +0.5% 973.62 KB 979.58 KB 217.22 KB 218.4 KB FB_WWW_DEV
ReactDOM-prod.js 0.0% -0.0% 395.81 KB 395.81 KB 73.42 KB 73.42 KB FB_WWW_PROD
react-dom-server.browser.development.js 0.0% -0.0% 136.98 KB 136.98 KB 36.33 KB 36.33 KB NODE_DEV
ReactDOM-profiling.js 0.0% -0.0% 406.34 KB 406.34 KB 75.18 KB 75.18 KB FB_WWW_PROFILING
react-dom-server.browser.production.min.js 0.0% -0.0% 20.26 KB 20.26 KB 7.51 KB 7.51 KB NODE_PROD
ReactDOMServer-dev.js 0.0% -0.0% 142.51 KB 142.51 KB 36.26 KB 36.26 KB FB_WWW_DEV
ReactDOMServer-prod.js 0.0% -0.0% 46.58 KB 46.58 KB 10.9 KB 10.9 KB FB_WWW_PROD

ReactDOM: size: 0.0%, gzip: -0.0%

Size changes (experimental)

Generated by 🚫 dangerJS against e9fcc79

bvaughn
bvaughn commented Jun 16, 2020
View reviewed changes
acdlite
acdlite reviewed Jun 16, 2020
View reviewed changes
Re-enabled DebugTracing feature for old reconciler fork
e9fcc79 
It was temporarily removed by @sebmarkbage via PR facebook#18697. Newly re-added tracing is simplified, since the lane(s) data type does not require the (lossy) conversion between priority and expiration time values.

@sebmarkbage mentioned that he removed this because it might get in the way of his planned discrete/sync refactor. I'm not sure if that concern still applies, but just in case- I have only re-added it to the old reconciler fork for now.
@bvaughn bvaughn force-pushed the reenable-DebugTracing branch from 7c05fc9 to e9fcc79 Compare June 16, 2020 18:55
@bvaughn bvaughn merged commit cc7c1ae into facebook:master Jun 16, 2020
@bvaughn bvaughn deleted the reenable-DebugTracing branch June 16, 2020 19:16
@taneliang taneliang mentioned this pull request Jun 17, 2020
Closed
15 tasks
lunaruan added a commit to lunaruan/react that referenced this pull request Jun 19, 2020
@lunaruan
Revert "Re-enabled DebugTracing feature for old reconciler fork (face…
0b1a540 
…book#19142)"

This reverts commit cc7c1ae.
lunaruan added a commit that referenced this pull request Jun 19, 2020
@lunaruan
Revert "Re-enabled DebugTracing feature for old reconciler fork (#19142…
d1d9054 
…)" (#19159)

This reverts commit cc7c1ae.
bvaughn pushed a commit to bvaughn/react that referenced this pull request Jun 19, 2020
Re-enabled DebugTracing feature for old reconciler fork (facebook#19142)
01451bb 
It was temporarily removed by @sebmarkbage via PR facebook#18697. Newly re-added tracing is simplified, since the lane(s) data type does not require the (lossy) conversion between priority and expiration time values.

@sebmarkbage mentioned that he removed this because it might get in the way of his planned discrete/sync refactor. I'm not sure if that concern still applies, but just in case- I have only re-added it to the old reconciler fork for now.
trueadm pushed a commit to trueadm/react that referenced this pull request Jun 22, 2020
@trueadm
Re-enabled DebugTracing feature for old reconciler fork (facebook#19142)
3ea9417 
It was temporarily removed by @sebmarkbage via PR facebook#18697. Newly re-added tracing is simplified, since the lane(s) data type does not require the (lossy) conversion between priority and expiration time values.

@sebmarkbage mentioned that he removed this because it might get in the way of his planned discrete/sync refactor. I'm not sure if that concern still applies, but just in case- I have only re-added it to the old reconciler fork for now.
trueadm pushed a commit to trueadm/react that referenced this pull request Jun 22, 2020
@lunaruan @trueadm
Revert "Re-enabled DebugTracing feature for old reconciler fork (face…
b8c2d4d 
…book#19142)" (facebook#19159)

This reverts commit cc7c1ae.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@acdlite acdlite acdlite approved these changes

@sebmarkbage sebmarkbage Awaiting requested review from sebmarkbage

@lunaruan lunaruan Awaiting requested review from lunaruan

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bvaughn @sizebot @acdlite @facebook-github-bot