[react-events] Focus/FocusWithin responders with fallbacks#16343
Merged
necolas merged 1 commit intofacebook:masterfrom Aug 12, 2019
Merged
[react-events] Focus/FocusWithin responders with fallbacks#16343necolas merged 1 commit intofacebook:masterfrom
necolas merged 1 commit intofacebook:masterfrom
Conversation
Details of bundled changes.Comparing: 5b00757...ea43995 react-events
Generated by 🚫 dangerJS |
2e42846 to
1577443
Compare
Separate the PointerEvent and fallback implementations. Fix the unit tests to cover both PointerEvent and non-PointerEvent environments. Fix the focus-visible related callbacks to get called when keys other than "Tab" are used.
1577443 to
ea43995
Compare
TrySound
reviewed
Aug 11, 2019
|
|
||
| const rootEventTypes = hasPointerEvents | ||
| ? ['keydown', 'keyup', 'pointermove', 'pointerdown', 'pointerup'] | ||
| : ['keydown', 'keyup', 'mousedown', 'touchmove', 'touchstart', 'touchend']; |
Contributor
There was a problem hiding this comment.
mouseup and mousemove are missing. Is it intentional?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate the PointerEvent and fallback implementations.
Fix the unit tests to cover both PointerEvent and non-PointerEvent environments.
Fix the focus-visible related callbacks to get called when keys other than "Tab" are used.