Update refs even if shouldComponentUpdate is false #1393
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes facebook#1392. I think this makes sense; it's useful to be able to reorder components without rerendering them while having refs that correspond to the current indices. Test Plan: grunt test
Contributor
|
If I understand you correctly, the ref for a component is not updated unless the component also updates? That sounds like a bug to me. |
Collaborator
Author
|
Yes; the test here failed before with static0's text still |
Contributor
|
Internal diff uncreated, lol. |
Collaborator
Author
|
Just wrote #1560 which should make it easier to refactor this to make more sense. |
Contributor
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Member
|
@sebmarkbage Can you close this out if we're not going to move forward? |
Contributor
|
This probably still makes sense to fix if we can do it non-hacky. |
Collaborator
Author
|
Yeah, planning on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1392.
I think this makes sense; it's useful to be able to reorder components without rerendering them while having refs that correspond to the current indices.
Test Plan: grunt test