Skip to content

added hasOwnProperty checks for object iteration #1385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zichun wants to merge 2 commits into from
Closed

added hasOwnProperty checks for object iteration #1385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf2aa0a
added hasOwnProperty checks for object iteration
zichun Apr 9, 2014
529cb03
fixed typo: prob->prop
zichun Apr 9, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/browser/ui/dom/DOMProperty.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ var DOMPropertyInjection = {
}

for (var propName in Properties) {
if (!Properties.hasOwnProperty(propName)) {
continue;
}
invariant(
!DOMProperty.isStandardName[propName],
'injectDOMPropertyConfig(...): You\'re trying to inject DOM property ' +
Expand Down
6 changes: 6 additions & 0 deletions src/event/EventPluginRegistry.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ function recomputePluginOrdering() {
return;
}
for (var pluginName in namesToPlugins) {
if (!namesToPlugins.hasOwnProperty(pluginName)) {
continue;
}
var PluginModule = namesToPlugins[pluginName];
var pluginIndex = EventPluginOrder.indexOf(pluginName);
invariant(
Expand All @@ -62,6 +65,9 @@ function recomputePluginOrdering() {
EventPluginRegistry.plugins[pluginIndex] = PluginModule;
var publishedEvents = PluginModule.eventTypes;
for (var eventName in publishedEvents) {
if (!publishedEvents.hasOwnProperty(eventName)) {
continue;
}
invariant(
publishEventForPlugin(
publishedEvents[eventName],
Expand Down